reproducible builds: build example themes reproducibly#49
Open
vagrantc wants to merge 4 commits intoopenSUSE:masterfrom
Open
reproducible builds: build example themes reproducibly#49vagrantc wants to merge 4 commits intoopenSUSE:masterfrom
vagrantc wants to merge 4 commits intoopenSUSE:masterfrom
Conversation
Apply fixes for reproducibilty, similar to: openSUSE#35 See also: https://bugs.debian.org/978946 https://tests.reproducible-builds.org/debian/issues/unstable/users_and_groups_in_cpio_archive_issue.html
The "." directory is at best extraneous, and is a little trickier to avoid a resulting embedded timestamp. See also: https://bugs.debian.org/978946 https://tests.reproducible-builds.org/debian/issues/unstable/timestamps_in_cpio_archive_issue.html
…akefile as a reference time. Similar to fixes applied in other themes: openSUSE#35 See also: https://bugs.debian.org/978946 https://tests.reproducible-builds.org/debian/issues/unstable/timestamps_in_cpio_archive_issue.html
Author
|
Apparently using the Makefile as a reference isn't quite working reliably: https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/gfxboot.html I'm testing a patch that uses the example*.bc as a reference instead. |
(Closes: #978946) Apparently the Makefile might be modified during the build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes changes to "gfxboot" and themes/example*/Makefile very similar to the changes applied in:
#35
Bug reported in Debian:
https://bugs.debian.org/978946
Related reproducible builds Issues tracked in Debian:
https://tests.reproducible-builds.org/debian/issues/unstable/users_and_groups_in_cpio_archive_issue.html
https://tests.reproducible-builds.org/debian/issues/unstable/timestamps_in_cpio_archive_issue.html